Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(primitives): rename State/Storage to EvmState/EvmStorage #1459

Merged
merged 5 commits into from
May 28, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented May 27, 2024

Rename type so it does not collide with revm::db::State

Copy link
Contributor

github-actions bot commented May 27, 2024

Valgrind Results:

==3806== Cachegrind, a cache and branch-prediction profiler
==3806== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3806== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3806== Command: target/release/snailtracer
==3806== 
--3806-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.816510926s
==3806== 
==3806== I   refs:      429,372,444
==3806== I1  misses:          3,251
==3806== LLi misses:          2,798
==3806== I1  miss rate:        0.00%
==3806== LLi miss rate:        0.00%
==3806== 
==3806== D   refs:      206,205,315  (133,650,807 rd   + 72,554,508 wr)
==3806== D1  misses:        344,589  (    204,514 rd   +    140,075 wr)
==3806== LLd misses:        137,611  (      4,259 rd   +    133,352 wr)
==3806== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3806== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3806== 
==3806== LL refs:           347,840  (    207,765 rd   +    140,075 wr)
==3806== LL misses:         140,409  (      7,057 rd   +    133,352 wr)
==3806== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita changed the title chore(primitives): rename State/Storage to PlainState/PlainStorage chore(primitives): rename State/Storage to EvmState/EvmStorage May 28, 2024
@rakita
Copy link
Member Author

rakita commented May 28, 2024

With new EvmStorage type we now have clear separation from Storage used inside Evm and Storage used inside db::State.

@rakita rakita merged commit a28a543 into main May 28, 2024
25 checks passed
This was referenced May 28, 2024
@rakita rakita deleted the rakita/rename_state branch June 1, 2024 12:54
This was referenced Jun 3, 2024
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants