Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add docs for BLS scalar input decoding #1446

Merged
merged 1 commit into from
May 24, 2024

Conversation

Rjected
Copy link
Collaborator

@Rjected Rjected commented May 20, 2024

After closing #1445, I decided to add docs to make sure the fact that we do not perform any Fr canonical checks is well-reasoned. This is actually specified in the EIP, so I decided to link it and annotate the code with the relevant part of the spec.

@Rjected Rjected added the hf-prague Prague related EIPs label May 20, 2024
Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great docs as always

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 44bafed into bluealloy:main May 24, 2024
21 of 25 checks passed
This was referenced Jun 8, 2024
This was referenced Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hf-prague Prague related EIPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants