feat: add Opcode::modifies_memory back #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
reviewed
May 15, 2024
| /// <https://bluealloy.github.io/revm/crates/interpreter/memory.html#opcodes> | ||
| /// <https://github.com/crytic/evm-opcodes> | ||
| #[inline] | ||
| pub const fn modifies_memory(&self) -> bool { |
There was a problem hiding this comment.
Would be good to integrate it inside in OpCodeInfo, but we should add bitfields for it and this lgtm
rakita
approved these changes
May 15, 2024
This was referenced May 15, 2024
Closed
Closed
Closed
This was referenced May 24, 2024
Closed
Closed
Closed
Closed
This was referenced May 31, 2024
Closed
Closed
Closed
Closed
This was referenced Jun 17, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously added here #1270
got lost for some reason