Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interpreter): expose mutable access methods on stack and memory #1219

Merged
merged 3 commits into from
Mar 22, 2024
Merged

feat(interpreter): expose mutable access methods on stack and memory #1219

merged 3 commits into from
Mar 22, 2024

Conversation

DaniPopes
Copy link
Collaborator

No description provided.

mattsse
mattsse reviewed Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those are very sensitive internals,
what's the use case you have in mind here?

@DaniPopes
Copy link
Collaborator Author

DaniPopes commented Mar 22, 2024 •
edited
Loading

We allow mutable access to almost everything else, like the bytecode raw ptr, we either lock everything or nothing

I want to clear stack and memory to run it in a standalone loop

@mattsse
Copy link
Collaborator

mattsse commented Mar 22, 2024

We allow mutable access to almost everything else

fair, not opposed to this, so defer to @rakita here

rakita
rakita approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 1ce5a52 into bluealloy:main Mar 22, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Mar 22, 2024
Closed
@DaniPopes DaniPopes deleted the stack-mut branch March 22, 2024 21:42
This was referenced Mar 25, 2024
Closed
Closed
Merged
fubuloubu pushed a commit to ApeWorX/revm that referenced this pull request Apr 11, 2024
@DaniPopes @fubuloubu
feat(interpreter): expose mutable access methods on stack and memory (b…
169cdc9 
…luealloy#1219)

* feat(interpreter): allow mutable stack access

* feat(interpreter): allow mutable memory access

* chore: inline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita rakita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniPopes @mattsse @rakita