Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PrecompileError::Other #1165

Merged

Conversation

fgimenez
Copy link
Collaborator

@fgimenez fgimenez commented Mar 7, 2024

Catch-all variant for custom precompiles failures.

@fgimenez fgimenez force-pushed the fgimenez/add-precompile-error-other-variant branch from 3289966 to 6a0bdfa Compare March 7, 2024 13:41
mattsse
mattsse previously requested changes Mar 7, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
we can add a function:

impl PrecompileError {

  pub fn other(err: impl Into<String>) -> Self {
     Self::Other(err.into())
  }
}

@fgimenez fgimenez force-pushed the fgimenez/add-precompile-error-other-variant branch from 0049150 to 65fd9ca Compare March 7, 2024 13:47
@fgimenez
Copy link
Collaborator Author

fgimenez commented Mar 7, 2024

we can add a function:

sure done

@rakita rakita merged commit ac99931 into bluealloy:main Mar 7, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
fubuloubu pushed a commit to ApeWorX/revm that referenced this pull request Apr 11, 2024
* feat: add PrecompileError::Other

* add PrecomileError::other
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants