LambdaMUD-Project

[upsmancsr]

@Dilstom

[TheDeterminator]

Cameron, this project looks great! You implemented your code well, you have detailed and frequent commits and you thought ahead by creating functionality for secret_key functionality which is no doubt an aspect of the project that craves reusability. Only thing I want to say is to remind you that the format for naming your pull requests should be: [FirstName LastName] - Name-of-Project. Thanks and great job!

[TheDeterminator]

Good that you added a link to your URL here. It's a small thing but many students forget/ignore that instruction.

[TheDeterminator]

This say command looks great! It might be nice to have a few more comments. Also have you thought about how you might handle the case where a user tries to send an empty message?

[TheDeterminator]

This is cool, I like how you set a file to do this secret key generation. It's good reusability and accessibility.

[upsmancsr]

Hey Alec, thanks so much for taking a look and proving this feedback. I've been working on the project but mainly adding styling and fun stuff. I need to also work on the small but important details as well, especially error handling for things like empty inputs and non-matching passwords for registration. I'm also going to try implementing a better authentication system that doesn't rely on storing the token in local storage.

…

On Wed, Dec 19, 2018 at 2:20 PM Alec Jordan ***@***.***> wrote: ***@***.**** commented on this pull request. Cameron, this project looks great! You implemented your code well, you have detailed and frequent commits and you thought ahead by creating functionality for secret_key functionality which is no doubt an aspect of the project that craves reusability. Only thing I want to say is to remind you that the format for naming your pull requests should be: [FirstName LastName] - Name-of-Project. Thanks and great job! ------------------------------ In README.md <#132 (comment)> : > @@ -1,3 +1,5 @@ +Cameron's Trello Board URL: https://trello.com/b/cjRCp0Co/lambdamud Good that you added a link to your URL here. It's a small thing but many students forget/ignore that instruction. ------------------------------ In adventure/api.py <#132 (comment)> : > @csrf_exempt @api_view(["POST"]) def say(request): # IMPLEMENT - return JsonResponse({'error':"Not yet implemented"}, safe=True, status=500) + player = request.user.player + player_id = player.id + player_uuid = player.uuid + data = json.loads(request.body) + message = data['message'] + room = player.room() + currentPlayerUUIDs = room.playerUUIDs(player_id) + for p_uuid in currentPlayerUUIDs: This say command looks great! It might be nice to have a few more comments. Also have you thought about how you might handle the case where a user tries to send an empty message? ------------------------------ In key_gen.py <#132 (comment)> : > @@ -0,0 +1,3 @@ +import random +key = ''.join([random.SystemRandom().choice('abcdefghijklmnopqrstuvwxyz0123456789!@#$%^&*(-_=+)') for i in range(50)]) This is cool, I like how you set a file to do this secret key generation. It's good reusability and accessibility. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#132 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AaQSL-owleaPHA_aXAw_C3rKBW-Vcy1mks5u6p-BgaJpZM4ZMaQx> .