-
Notifications
You must be signed in to change notification settings - Fork 66
Conversation
@@ -32,5 +36,16 @@ SERVER_JVMFLAGS="$SERVER_JVMFLAGS -Djava.security.auth.login.config=/etc/zookeep | |||
CLIENT_JVMFLAGS="$CLIENT_JVMFLAGS -Djava.security.auth.login.config=/etc/zookeeper/conf/zookeeper-client.jaas" | |||
<% end %> | |||
|
|||
<% | |||
auto_size = (node['memory']['total'].to_i * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move calculations outside tempates?
-%> | ||
SERVER_JVMFLAGS="$SERVER_JVMFLAGS -Xms<%= heap %>m -Xmx<%= heap %>m " \ | ||
"-Xmn<%= newsize %>m " \ | ||
"<%= node['bcpc']['hadoop']['zookeeper']['gc_opts'] %>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FC0035 is deprecated but I think this template has enough access to various parts of the node
Object that it is worth enforcing.
See Foodcritic/foodcritic#62 for background. Enforcing it is getting too draconian but it still makes sense to enforce in the other extreme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aespinosa I am not quite sure what direction you are wanting this to go in but at this time a change for node object access here should be consistent with the other -env.sh files we have and would be a broader scope of work than I am comfortable with for this change. For reference, we have the following if you want to file an issue to tackle this?
The original built a working cluster. Rebuilding to ensure post code-review changes also work. |
7ae6ab6
to
bbd7afd
Compare
bbd7afd
to
d3067d5
Compare
It looks like cluster-assign-roles.sh ran through after some unrelated network issues running behind proxies. |
@cbaenziger this doesn't backport cleanly. Mind sending a separate PR to the release-3.3 branch? |
This addresses the concerns of #1214 and #52 as well it brings in
locking_resource
for the Zookeeper servers themselves.