-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify related types together in class SimilarTypes
#34
Conversation
Signed-off-by: Siddhant Kumar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This looks great.
Hmm, I'm not sure what's happening with the continuous documentation. |
The docs are being rebuilt successfully on the pR: |
@kpfleming The continuous-documentation hook seems to be waiting for status indefinitely, but the build shows successful in readthedocs. I don't have access to check out the hook, would you mind checking it please ? |
@gaborbernat any thoughts on the read-the-docs not getting back the update ? |
This goes with @kpfleming, seems there's a check mandated for merge... but that check was renamed from |
All set... |
Thank you @kpfleming @saytosid ❤️ |
Signed-off-by: Fabian Raab <[email protected]>
Signed-off-by: Wilfred Wong <[email protected]>
Signed-off-by: Wilfred Wong <[email protected]>
Issue number of the reported bug or feature request: #33
Describe your changes
Unified the list of related types -
attrs-strict/attrs_strict/_type_validation.py
Lines 53 to 67 in c8052d9
Testing performed
This is a refactoring which should not have any functional change
Additional context
Split out from #25