Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify related types together in class SimilarTypes #34

Merged
merged 1 commit into from
May 22, 2020

Conversation

saytosid
Copy link
Contributor

Issue number of the reported bug or feature request: #33

Describe your changes
Unified the list of related types -

if base_type in {set, list, typing.List, typing.Set}:
_handle_set_or_list(attribute, value, expected_type)
elif base_type in {
dict,
collections.OrderedDict,
collections.defaultdict,
Mapping,
MutableMapping,
typing.Dict,
typing.DefaultDict,
typing.Mapping,
typing.MutableMapping,
}:
_handle_dict(attribute, value, expected_type)
elif base_type in {tuple, typing.Tuple}:

Testing performed
This is a refactoring which should not have any functional change

Additional context
Split out from #25

Copy link
Contributor

@erikseulean erikseulean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This looks great.

@erikseulean
Copy link
Contributor

Hmm, I'm not sure what's happening with the continuous documentation.

@erikseulean
Copy link
Contributor

The docs are being rebuilt successfully on the pR:

https://readthedocs.org/api/v2/build/11091145.txt

@erikseulean
Copy link
Contributor

@kpfleming The continuous-documentation hook seems to be waiting for status indefinitely, but the build shows successful in readthedocs. I don't have access to check out the hook, would you mind checking it please ?

@erikseulean
Copy link
Contributor

@gaborbernat any thoughts on the read-the-docs not getting back the update ?

@gaborbernat
Copy link
Contributor

This goes with @kpfleming, seems there's a check mandated for merge... but that check was renamed from continuous-documentation/read-the-docs to docs/readthedocs.org:attrs-strict. Branch protection needs to be updated, but only @kpfleming has the rights to do so.

@kpfleming
Copy link
Contributor

All set...

@gaborbernat gaborbernat merged commit 8e1a6de into bloomberg:master May 22, 2020
@erikseulean
Copy link
Contributor

Thank you @kpfleming @saytosid ❤️

@saytosid saytosid deleted the rfc/similar-types branch May 22, 2020 13:46
raabf pushed a commit to raabf/attrs-strict that referenced this pull request May 22, 2020
raabf pushed a commit to raabf/attrs-strict that referenced this pull request May 22, 2020
keiclone pushed a commit to keiclone/attrs-strict that referenced this pull request May 26, 2020
keiclone pushed a commit to keiclone/attrs-strict that referenced this pull request May 26, 2020
keiclone pushed a commit to keiclone/attrs-strict that referenced this pull request May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants