Fix handling of typing.Any #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I messed up something with the formatting, but I'll fix it later today. |
|
@erikseulean if you allow another maintainer to push (checkbox on right) can help you out with this. |
|
It's checked. |
|
There's also a typo in the commit message that I'll have to fix |
|
Hmm, it rejects me to push commits on top of it, maybe then I don't have maintainer rights here. |
Signed-off-by: Erik-Cristian Seulean <[email protected]>
So far Any was not taken in consideration and it was failing to handle it correctly. If the base_type is Any, stop the recursive check and return as if everything is fine. Signed-off-by: Erik-Cristian Seulean <[email protected]>
|
I moved the formatting on a different commit. |
gaborbernat
approved these changes
Apr 1, 2020
keiclone
pushed a commit
to keiclone/attrs-strict
that referenced
this pull request
May 26, 2020
* Black format Signed-off-by: Erik-Cristian Seulean <[email protected]> * Fix handling of typing.Any So far Any was not taken in consideration and it was failing to handle it correctly. If the base_type is Any, stop the recursive check and return as if everything is fine. Signed-off-by: Erik-Cristian Seulean <[email protected]> Signed-off-by: Wilfred Wong <[email protected]>
keiclone
pushed a commit
to keiclone/attrs-strict
that referenced
this pull request
May 26, 2020
* Black format Signed-off-by: Erik-Cristian Seulean <[email protected]> * Fix handling of typing.Any So far Any was not taken in consideration and it was failing to handle it correctly. If the base_type is Any, stop the recursive check and return as if everything is fine. Signed-off-by: Erik-Cristian Seulean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far Any was not taken in consideration and it was failing
to handle it correctly. If the base_type is Any, stop the
recursive check and return as if everything is fine.
Signed-off-by: Erik-Cristian Seulean [email protected]
*Issue number of the reported bug or feature request: #27