Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor dependency updates: late August edition #559

Merged
merged 6 commits into from
Aug 25, 2020
Merged

Conversation

bk3c
Copy link
Contributor

@bk3c bk3c commented Aug 24, 2020

There should be nothing of note here, but it would be great to get a few other pairs of eyes to make sure all is running well locally and there are no unintended consequences.

@exygy-dev exygy-dev temporarily deployed to bloom-refere-august-min-y2rtbt August 24, 2020 22:26 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-august-min-y2rtbt August 24, 2020 22:59 Inactive
@bk3c
Copy link
Contributor Author

bk3c commented Aug 24, 2020

a couple of notes:

  • I backed axios down to 0.19.2 since some dependencies we have use that pinned version, and we were running into conflicts based on two different versions since one was hoisted and the other wasn't. I don't think there's any huge rush to upgrade it, and we can get there once things catch up

  • There was a bunch of cruft in the yarn.lock, so I regenerated a fresh one which took the file size down by a few hundred lines.

  • There was an unrelated build problem introduced in Relocate the copy on the homepage #557 where we forgot to remove the reference to homepage.mdx from the public-reference error page. I went ahead and fixed that here so tests would pass (and shame on me for merging the other issue without noticing the failure)

  • Cypress, Partners, and Backend tests are still failing for unrelated reasons.

@bk3c bk3c added Ready for Review wip This PR is not ready for review, do not review it's a “Work In Progress” and removed Ready for Review labels Aug 24, 2020
@jaredcwhite
Copy link
Collaborator

Ooo, Tailwind 1.7! There's a bunch of improvements to the @apply feature…it's behind a applyComplexClasses config flag though.

@bk3c Should we try to switch that on as part of this PR, or investigate it separately?

@bk3c
Copy link
Contributor Author

bk3c commented Aug 24, 2020

Turns out that Prettier 2.1 breaks Storybook, so I'm going to hold off merging this until they fix it. There's already a big issue thread, so I expect it'll get sorted out in the next ~48 hours.

@bk3c
Copy link
Contributor Author

bk3c commented Aug 24, 2020

@jaredcwhite Up to you. I was thinking we could wait and do the new tailwind usage in a follow-on PR, but if you think it'll be relatively quick and easy, feel free to make adjustments here while we're waiting on the SB issue to get resolved.

@jaredcwhite
Copy link
Collaborator

@bk3c I'll give it a quick spin, but happy to keep it as-is if there are odd quirks.

@jaredcwhite
Copy link
Collaborator

Well…that is weird. Just switching applyComplexClasses to true causes the app startup to freeze, Node pegged at 100% and my fans revved up. Switching it back to false and everything seems fine. Tried back and forth a few times. I'll poke around the Tailwind repo issues to see if anyone else is seeing a similar freeze, but otherwise I guess we'll need to leave it off for the time being.

@jaredcwhite
Copy link
Collaborator

Ah, there IS an issue. I have to admit I'm surprised a problem this obvious made it into the 1.7 release. Oh well… tailwindlabs/tailwindcss#2192

@exygy-dev exygy-dev temporarily deployed to bloom-refere-august-min-y2rtbt August 25, 2020 19:23 Inactive
@bk3c
Copy link
Contributor Author

bk3c commented Aug 25, 2020

Ok, Storybook fix is in, so I'm going to go ahead and merge this.

@jaredcwhite - feel free to make yourself an issue for the Tailwind @apply updates if you like, or we can just get back to it whenever it's working again.

@bk3c bk3c merged commit e5904c1 into master Aug 25, 2020
@bk3c bk3c deleted the august-minor-deps branch September 14, 2020 16:39
seanmalbert referenced this pull request in housingbayarea/bloom Apr 12, 2022
jaredcwhite pushed a commit that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip This PR is not ready for review, do not review it's a “Work In Progress”
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants