Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comparers): StringSliceComparer #6

Merged
merged 5 commits into from
Apr 8, 2022

Conversation

arsham
Copy link
Contributor

@arsham arsham commented Apr 8, 2022

This PR adds a new comparer for string slices. (Close #5)
It stops sorting slices in-place. (Close #4)

@arsham arsham self-assigned this Apr 8, 2022
@github-actions github-actions bot added the ci label Apr 8, 2022
@arsham arsham added the enhancement New feature or request label Apr 8, 2022
@github-actions github-actions bot added documentation Improvements or additions to documentation comparers errors labels Apr 8, 2022
@arsham arsham force-pushed the feature/5/string_slice_comparer branch from 618812f to 9e12fed Compare April 8, 2022 14:00
@arsham arsham merged commit 1337b45 into master Apr 8, 2022
@arsham arsham deleted the feature/5/string_slice_comparer branch April 8, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci comparers documentation Improvements or additions to documentation enhancement New feature or request errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: StringSliceComparer Sorters could avoid sorting the input slices
1 participant