Fixes in validators, fixes in parsing Oracle Discovery DTO

packages/apps/human-app/server/src/common/config/params-decorators.ts

@@ -1,4 +1,5 @@
 import { createParamDecorator, ExecutionContext } from '@nestjs/common';
+import { Transform } from 'class-transformer';
 import { jwtDecode } from 'jwt-decode';
 import { JwtUserData } from '../utils/jwt-token.model';
 
@@ -22,3 +23,12 @@ export const JwtPayload = createParamDecorator(
     }
   },
 );
+
+export function TransformToArray() {
+  return Transform(({ value }) => {
+    if (!value) {
+      return undefined;
+    }
+    return Array.isArray(value) ? value : [value];
+  });
+}

packages/apps/human-app/server/src/main.ts

@@ -2,7 +2,7 @@ import { NestFactory } from '@nestjs/core';
 import { AppModule } from './app.module';
 import { DocumentBuilder, SwaggerModule } from '@nestjs/swagger';
 import { ConfigService } from '@nestjs/config';
-import { Logger } from '@nestjs/common';
+import { Logger, ValidationPipe } from '@nestjs/common';
 import { EnvironmentConfigService } from './common/config/environment-config.service';
 import { GlobalExceptionsFilter } from './common/filter/global-exceptions.filter';
 
@@ -31,6 +31,7 @@ async function bootstrap() {
   const port = envConfigService.port;
 
   app.useGlobalFilters(new GlobalExceptionsFilter());
+  app.useGlobalPipes(new ValidationPipe({ transform: true }));
 
   await app.listen(port, host, async () => {
     logger.log(`Human APP server is running on http://${host}:${port}`);

packages/apps/human-app/server/src/modules/oracle-discovery/model/oracle-discovery.model.ts

@@ -1,6 +1,8 @@
 import { IOperator } from '@human-protocol/sdk';
 import { AutoMap } from '@automapper/classes';
 import { ApiPropertyOptional } from '@nestjs/swagger';
+import { IsString } from 'class-validator';
+import { Transform } from 'class-transformer';
 
 export class OracleDiscoveryResponse implements IOperator {
   address: string;
@@ -15,11 +17,12 @@ export class OracleDiscoveryResponse implements IOperator {
   }
 }
 export class OracleDiscoveryDto {
-  @AutoMap()
-  @ApiPropertyOptional()
+  @ApiPropertyOptional({ type: [String], isArray: true })
+  @Transform(({ value }) => (Array.isArray(value) ? value : Array(value)))
   selected_job_types?: string[];
 }
 export class OracleDiscoveryCommand {
   @AutoMap()
+  @Transform(({ value }) => (Array.isArray(value) ? value : [value]))
   selectedJobTypes?: string[];
 }

packages/apps/human-app/server/src/modules/oracle-discovery/oracle-discovery.controller.ts

@@ -26,7 +26,7 @@ export class OracleDiscoveryController {
   @ApiOperation({ summary: 'Oracles discovery' })
   @UsePipes(new ValidationPipe())
   public getOracles(
-    @Query() dto?: OracleDiscoveryDto,
+    @Query() dto: OracleDiscoveryDto,
   ): Promise<OracleDiscoveryResponse[]> {
     const command = this.mapper.map(
       dto,

packages/apps/human-app/server/src/modules/oracle-discovery/oracle-discovery.service.ts

@@ -22,7 +22,6 @@ export class OracleDiscoveryService {
   ): Promise<OracleDiscoveryResponse[]> {
     const address = this.configService.reputationOracleAddress;
     const chainIds = this.configService.chainIdsEnabled;
-
     const filteredOracles = await Promise.all(
       chainIds.map(async (chainId) => {
         return this.findOraclesByChainId(chainId, address).then((oracles) =>
@@ -69,18 +68,22 @@ export class OracleDiscoveryService {
       !foundOracles ||
       foundOracles.length === 0
     ) {
+      console.log('DUPA1');
       return foundOracles;
     }
-    return foundOracles.filter((oracle) =>
+    const filteredOracles = foundOracles.filter((oracle) =>
       oracle.jobTypes && oracle.jobTypes.length > 0
         ? this.areJobTypeSetsIntersect(oracle.jobTypes, selectedJobTypes)
         : false,
     );
+    return filteredOracles;
   }
   private areJobTypeSetsIntersect(
     oracleJobTypes: string[],
     requiredJobTypes: string[],
   ) {
+    console.log(requiredJobTypes);
+    console.log(oracleJobTypes);
     return oracleJobTypes.some((job) =>
       requiredJobTypes
         .map((requiredJob) => requiredJob.toLowerCase())