Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(plonky2_prove): Add test for casts from lower bit length to higher on signed integers #85

Merged
merged 1 commit into from
Sep 17, 2024
Merged

test(plonky2_prove): Add test for casts from lower bit length to higher on signed integers #85

merged 1 commit into from
Sep 17, 2024

Conversation

Syndamia
Copy link

No description provided.

@Syndamia Syndamia changed the base branch from master to blocksense September 16, 2024 13:34
@blocksense-network blocksense-network deleted a comment from github-actions bot Sep 16, 2024
nickysn
nickysn requested changes Sep 17, 2024
View reviewed changes
Copy link

@nickysn nickysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix.

test_programs/plonky2_prove_failure/signed_casts/Prover.toml Show resolved Hide resolved
test_programs/plonky2_prove_failure/signed_casts/src/main.nr Show resolved Hide resolved
nickysn
nickysn approved these changes Sep 17, 2024
View reviewed changes
Copy link

@nickysn nickysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Syndamia Syndamia merged commit bedd2d3 into blocksense Sep 17, 2024
1 of 2 checks passed
@Syndamia Syndamia deleted the test/signed_casts branch September 17, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickysn nickysn nickysn approved these changes

@Aristotelis2002 Aristotelis2002 Awaiting requested review from Aristotelis2002

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syndamia @nickysn