Skip to content

Commit

Permalink
chore(ci): run clippy on benchmarks (noir-lang#4988)
Browse files Browse the repository at this point in the history
# Description

## Problem\*

Resolves <!-- Link to GitHub Issue -->

## Summary\*

We're not currently checking the benchmarks in CI which has resulted in
them no longer compiling. This PR adds them to the clippy checks which
will enforce that they compile properly.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
  • Loading branch information
TomAFrench authored May 7, 2024
1 parent e5f356b commit 9f2c21d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/formatting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
save-if: ${{ github.event_name != 'merge_group' }}

- name: Run `cargo clippy`
run: cargo clippy --workspace --locked --release
run: cargo clippy --all-targets --workspace --locked --release

- name: Run `cargo fmt`
run: cargo fmt --all --check
Expand Down
1 change: 1 addition & 0 deletions acvm-repo/acir/benches/serialization.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ fn sample_program(num_opcodes: usize) -> Program {
assert_messages: Vec::new(),
recursive: false,
}],
unconstrained_functions: Vec::new(),
}
}

Expand Down

0 comments on commit 9f2c21d

Please sign in to comment.