fix: let LSP suggest fields and methods in LValue chains (#6051) #20
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Report Brillig bytecode size diff | |
| on: | |
| push: | |
| branches: | |
| - master | |
| pull_request: | |
| jobs: | |
| build-nargo: | |
| runs-on: ubuntu-latest | |
| strategy: | |
| matrix: | |
| target: [x86_64-unknown-linux-gnu] | |
| steps: | |
| - name: Checkout Noir repo | |
| uses: actions/checkout@v4 | |
| - name: Setup toolchain | |
| uses: dtolnay/[email protected] | |
| - uses: Swatinem/rust-cache@v2 | |
| with: | |
| key: ${{ matrix.target }} | |
| cache-on-failure: true | |
| save-if: ${{ github.event_name != 'merge_group' }} | |
| - name: Build Nargo | |
| run: cargo build --package nargo_cli --release | |
| - name: Package artifacts | |
| run: | | |
| mkdir dist | |
| cp ./target/release/nargo ./dist/nargo | |
| 7z a -ttar -so -an ./dist/* | 7z a -si ./nargo-x86_64-unknown-linux-gnu.tar.gz | |
| - name: Upload artifact | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: nargo | |
| path: ./dist/* | |
| retention-days: 3 | |
| compare_brillig_bytecode_size_reports: | |
| needs: [build-nargo] | |
| runs-on: ubuntu-latest | |
| permissions: | |
| pull-requests: write | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Download nargo binary | |
| uses: actions/download-artifact@v4 | |
| with: | |
| name: nargo | |
| path: ./nargo | |
| - name: Set nargo on PATH | |
| run: | | |
| nargo_binary="${{ github.workspace }}/nargo/nargo" | |
| chmod +x $nargo_binary | |
| echo "$(dirname $nargo_binary)" >> $GITHUB_PATH | |
| export PATH="$PATH:$(dirname $nargo_binary)" | |
| nargo -V | |
| - name: Generate Brillig bytecode size report | |
| working-directory: ./test_programs | |
| run: | | |
| chmod +x gates_report_brillig.sh | |
| ./gates_report_brillig.sh | |
| mv gates_report_brillig.json ../gates_report_brillig.json | |
| - name: Compare Brillig bytecode size reports | |
| id: brillig_bytecode_diff | |
| uses: noir-lang/noir-gates-diff@3fb844067b25d1b59727ea600b614503b33503f4 | |
| with: | |
| report: gates_report_brillig.json | |
| header: | | |
| # Changes to Brillig bytecode sizes | |
| brillig_report: true | |
| summaryQuantile: 0.9 # only display the 10% most significant bytecode size diffs in the summary (defaults to 20%) | |
| - name: Add bytecode size diff to sticky comment | |
| if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target' | |
| uses: marocchino/sticky-pull-request-comment@v2 | |
| with: | |
| header: brillig | |
| # delete the comment in case changes no longer impact brillig bytecode sizes | |
| delete: ${{ !steps.brillig_bytecode_diff.outputs.markdown }} | |
| message: ${{ steps.brillig_bytecode_diff.outputs.markdown }} |