Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hyphen in database name #5778

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Allow hyphen in database name #5778

merged 3 commits into from
Jul 29, 2022

Conversation

royki
Copy link
Contributor

@royki royki commented Jul 28, 2022

Motivation

Hyphen is not allowed in the Database Name

Changelog

Allow hyphen in Database Name.

Bug Fixes

  1. Database name with hyphen(-) throws error of - "database \"test\" does not exist", pg_code: "3D000" as the database config parser is not able to read the database name with hypen i.e test-database.
  2. Example of details error log -> https://gist.github.com/royki/c0132f8b8b42362ee81e809794506489
  3. This use case doesn't exit in test case -> https://github.com/blockscout/blockscout/blob/master/apps/explorer/test/explorer/repo/config_helper_test.exs
  4. It is actually removed from test case -> https://github.com/blockscout/blockscout/pull/5192/files

Checklist for your Pull Request (PR)

@vbaranov
Copy link
Member

@royki thank you. Curious, what tool did you use for formatting .md files?

@vbaranov vbaranov self-requested a review July 28, 2022 15:28
@royki
Copy link
Contributor Author

royki commented Jul 28, 2022

@royki thank you. Curious, what tool did you use for formatting .md files?

Hi @vbaranov , thanks for looking into the PR.
I use this one -> https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint

@vbaranov vbaranov merged commit 971b5d1 into blockscout:master Jul 29, 2022
@royki royki deleted the fix-db-name branch July 29, 2022 08:43
sidhujag pushed a commit to syscoin/blockscout that referenced this pull request Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants