Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix staking Theme colors UI issues (from #2292) #2700

Merged
merged 10 commits into from
Sep 18, 2019
Merged

Fix staking Theme colors UI issues (from #2292) #2700

merged 10 commits into from
Sep 18, 2019

Conversation

liberumed
Copy link
Contributor

@liberumed liberumed commented Sep 16, 2019 •
edited
Loading

Motivation

This PR is made to fix remain UI issues related to the theme colors for POSDAO Staking DApp, directly #2292 (comment)
This is a more clean version of #2618 , so should contain commits for each fix and remove some unnecessary logic.

Changelog

  • Fix button color in dark mode on Error Status modal (8)
  • Fix dark theme color in stake dialog modals (10)
  • Fix dark theme color for the empty state in stake pools list (11)
  • Fix dark theme color for the non-empty state in stake pools list
  • Fix delegators list modal width for inactive pools (Again 2)
  • Fix dark theme color for banned pools
  • Fix differences in transition speed for input prepend block (2700.3)
  • Fix dark theme color for input autofill (Fix staking Theme colors UI issues (from #2292) #2700.1)
  • Fix chart color in staking modals (Fix staking Theme colors UI issues (from #2292) #2700.2)

@liberumed liberumed self-assigned this Sep 16, 2019
@coveralls
Copy link

coveralls commented Sep 16, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build b693a25e-701c-442f-acfe-7627ab195691

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-2.6%) to 74.77%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
Totals Coverage Status
Change from base Build da4c2b6b-1ce4-48b8-8062-56ad7e6fa974: -2.6%
Covered Lines: 5029
Relevant Lines: 6726
💛 - Coveralls

vbaranov
vbaranov requested changes Sep 17, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liberumed

  1. white input background on mouse hover to auto-substitution
    Screenshot 2019-09-17 at 13 22 54

  2. circle's wrong colour on first time opening. On the 2nd time, it becomes green
    Screenshot 2019-09-17 at 13 24 44

  3. different speed of appearing of green border's parts

https://www.loom.com/share/092ee3ea6a4b44de8a8726051cf2d54a

vbaranov
vbaranov approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liberumed gettext test should be fixed - it is failing. My issues, that I posted in the previous review, were resolved. I didn't find more issues related to the dark theme.

@goodsoft
Copy link
Contributor

@vbaranov we will make a separate commit in the #2292 for gettext to avoid merging conflicts while that PR is still WIP.

@goodsoft goodsoft merged commit f6875f6 into staking Sep 18, 2019
liberumed added a commit that referenced this pull request Sep 27, 2019
@liberumed
Fix staking Theme colors UI issues (from #2292) (#2700)
3e909b6 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
liberumed added a commit that referenced this pull request Sep 27, 2019
@liberumed
Fix staking Theme colors UI issues (from #2292) (#2700)
c0be561 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
liberumed added a commit that referenced this pull request Oct 15, 2019
@liberumed
Fix Staking DApp theme colors (#2700)
6343a7c 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
liberumed added a commit that referenced this pull request Oct 16, 2019
@liberumed
Fix Staking DApp theme colors (#2700)
04eb073 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
liberumed added a commit that referenced this pull request Oct 16, 2019
@liberumed
Fix Staking DApp theme colors (#2700)
5629dbf 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
liberumed added a commit that referenced this pull request Oct 16, 2019
@liberumed
Fix Staking DApp theme colors (#2700)
77eb24f 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
liberumed added a commit that referenced this pull request Oct 16, 2019
@liberumed
Fix Staking DApp theme colors (#2700)
d3da9f5 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
liberumed added a commit that referenced this pull request Oct 21, 2019
@liberumed
Fix Staking DApp theme colors (#2700)
254a6cc 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
@lucasege lucasege mentioned this pull request Dec 2, 2019
Merged
vbaranov pushed a commit that referenced this pull request Sep 9, 2020
@liberumed @vbaranov
Fix Staking DApp theme colors (#2700)
095d17f 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
vbaranov pushed a commit that referenced this pull request Sep 11, 2020
@liberumed @vbaranov
Fix Staking DApp theme colors (#2700)
caca8a6 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
vbaranov pushed a commit that referenced this pull request Sep 14, 2020
@liberumed @vbaranov
Fix Staking DApp theme colors (#2700)
c02ef34 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
vbaranov pushed a commit that referenced this pull request Oct 1, 2020
@liberumed @vbaranov
Fix Staking DApp theme colors (#2700)
9c7e09c 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
vbaranov pushed a commit that referenced this pull request Oct 2, 2020
@liberumed @vbaranov
Fix Staking DApp theme colors (#2700)
61a5fe5 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
vbaranov pushed a commit that referenced this pull request Oct 12, 2020
@liberumed @vbaranov
Fix Staking DApp theme colors (#2700)
ab8e6cb 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
vbaranov pushed a commit that referenced this pull request Oct 15, 2020
@liberumed @vbaranov
Fix Staking DApp theme colors (#2700)
2f63c95 
* Fix button color in dark mode on Error Status modal

* Fix dark theme color in stake dialog modals

* Fix dark theme color for empty state in stake pools list

* Fix dark theme color for non-empty state in stake pools list

* Fix delegators list modal width for inactive pools

* Fix dark theme color for banned pools

* Fix differences in transition speed for input prepend block

* Fix dark theme color for input autofill

* Fix chart color in staking modals

* Fix to hide only tooltips that triggered by elements inside stakes top block
@Jircs1 Jircs1 mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@goodsoft goodsoft goodsoft approved these changes

Assignees

@liberumed liberumed

Labels
Staking dApp wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liberumed @coveralls @goodsoft @vbaranov