Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide loading message when fetching is failed #2520

Merged
merged 6 commits into from
Aug 8, 2019
Merged

Conversation

saneery
Copy link
Contributor

@saneery saneery commented Aug 7, 2019

#2513

Motivation

After the fail of fetching items, we should hide the loading screen

Before

image

After

image

@coveralls
Copy link

coveralls commented Aug 7, 2019

Pull Request Test Coverage Report for Build da96a6d1-ddf5-41dd-9d26-d237e4887b26

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.329%

Totals Coverage Status
Change from base Build 285516f9-1aed-4e3e-b637-21e42da43a25: 0.0%
Covered Lines: 5177
Relevant Lines: 6526

💛 - Coveralls

Copy link
Contributor

@ayrat555 ayrat555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One comment

apps/block_scout_web/assets/js/lib/async_listing_load.js Outdated Show resolved Hide resolved
@saneery saneery requested a review from ayrat555 August 8, 2019 11:07
@vbaranov vbaranov merged commit 3cd8f02 into master Aug 8, 2019
@vbaranov vbaranov deleted the hide-loading-message branch August 8, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants