Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "page not found" handling in the router #2416

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jul 23, 2019

Motivation

BS renders Page not found view if the path consists only from one part in URL (for instance /1). If the wrong path consists of multiple parts (for instance /1/2/3/4/5/6/), Blockscout doesn't handle them.

Changelog

Bug Fixes

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@vbaranov vbaranov self-assigned this Jul 23, 2019
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Jul 23, 2019
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a question

@vbaranov vbaranov merged commit d1b06ec into master Jul 24, 2019
@vbaranov vbaranov deleted the vb-router-fixes branch July 24, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants