Fix "page not found" handling in the router #2416
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
BS renders
Page not found
view if the path consists only from one part in URL (for instance/1
). If the wrong path consists of multiple parts (for instance/1/2/3/4/5/6/
), Blockscout doesn't handle them.Changelog
Bug Fixes
search mask for
Page not found
page changed to:https://github.com/poanetwork/blockscout/blob/7187e5766047df8fb0cf4840abb63f0b3616fa90/apps/block_scout_web/lib/block_scout_web/router.ex#L264
Added missing function clauses for various controllers, that causes
Internal server error
when trying to open corresponding pages.Checklist for your PR
CHANGELOG.md
with this PR