Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add market history cache #2182

Merged
merged 18 commits into from
Jun 21, 2019
Merged

add market history cache #2182

merged 18 commits into from
Jun 21, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jun 17, 2019 •
edited
Loading

resolves #1880
resolves #2035

@coveralls
Copy link

coveralls commented Jun 17, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 557a962f-ef22-4a3c-9677-2feee876abb3

  • 24 of 25 (96.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 81.069%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/chain.ex 0 1 0.0%
Totals Coverage Status
Change from base Build 4d4c76eb-21a8-40ff-979f-4f765b9a22da: 0.1%
Covered Lines: 5019
Relevant Lines: 6191
💛 - Coveralls

pasqu4le
pasqu4le approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a minor suggestion

apps/explorer/lib/explorer/market/market_history_cache.ex
@last_update_key :last_update
@history_key :history
# 6 hours
@cache_period 1_000 * 60 * 60 * 6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use erlang timer library here :timer.hours(6) and avoid the comment as well

vbaranov
vbaranov reviewed Jun 20, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 should this PR close #2035 too ?

@ayrat555
Copy link
Contributor Author

@vbaranov yes

@vbaranov vbaranov self-requested a review June 20, 2019 13:02
vbaranov
vbaranov reviewed Jun 20, 2019
View reviewed changes
CHANGELOG.md
@@ -1,4 +1,6 @@
## Current
### Features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 there is a doubled Features section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@vbaranov
Copy link
Member

@ayrat555 something wrong with gettext test

@ayrat555
Copy link
Contributor Author

@vbaranov it was ci bug. now everything's ok

@vbaranov vbaranov merged commit 90bae34 into master Jun 21, 2019
@vbaranov vbaranov deleted the ab-cache-for-chart-data branch June 21, 2019 11:38
@vbaranov vbaranov mentioned this pull request Jun 26, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

@zachdaniel zachdaniel Awaiting requested review from zachdaniel

@saneery saneery Awaiting requested review from saneery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put pricing chart data to ETS Slow performance of the main page: use ETS
4 participants
@ayrat555 @coveralls @vbaranov @pasqu4le