-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) txs errors color #2025
Merged
Merged
(fix) txs errors color #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbaranov
approved these changes
May 25, 2019
vbaranov
requested changes
May 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<span class="tile-status-label ml-2 ml-md-0" data-test="transaction_status">
Error: (Awaiting internal transactions for reason)
</span>
* master: Update CHANGELOG.md Update CHANGELOG.md Update _dropdown.scss Update _dai_variables.scss Update CHANGELOG.md Update _dai_variables.scss Update dai_logo.svg (update) changelog (fix) wrong tabs behavior (update) changelog (update) language files (fix) Missing tx hashes Add CHANGELOG entry Use PORT env variable in dev config # Conflicts: # CHANGELOG.md
Fixed it. This one can be tricky, because each error has a different CSS class name, so it would necessary to create a rule for each error. I created a "catch all" CSS rule that should solve this problem, but YMMV. |
vbaranov
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1934
Motivation
To add a new color to display transactions' errors.
Changelog
Bug Fixes
Checklist for your PR
CHANGELOG.md
with this PR