Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block counter calculates only consensus blocks #1838

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Block counter calculates only consensus blocks #1838

merged 2 commits into from
Apr 26, 2019

Conversation

saneery
Copy link
Contributor

@saneery saneery commented Apr 25, 2019

Fixes bug where block counter and blocks list disagrees

image

@ghost ghost assigned saneery Apr 25, 2019
@ghost ghost added the in progress label Apr 25, 2019
@saneery saneery changed the title Block counter calculate only consensus blocks Block counter calculates only consensus blocks Apr 25, 2019
@saneery saneery marked this pull request as ready for review April 25, 2019 10:56
@coveralls
Copy link

coveralls commented Apr 25, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1b01d5c7-62bb-4843-a1ac-c356b9c67209

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 82.2%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/channels/exchange_rate_channel.ex 1 50.0%
Totals Coverage Status
Change from base Build 3a837abf-ea5a-4e18-9331-4e90fed4c037: -0.01%
Covered Lines: 4447
Relevant Lines: 5410
💛 - Coveralls

@saneery saneery added the ready for review This PR is ready for reviews. label Apr 25, 2019
@vbaranov vbaranov merged commit 251f076 into master Apr 26, 2019
@ghost ghost removed the in progress label Apr 26, 2019
@vbaranov vbaranov deleted the block_counter_fix branch April 26, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

@vbaranov vbaranov vbaranov approved these changes

@goodsoft goodsoft goodsoft approved these changes

Assignees

@saneery saneery

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saneery @coveralls @goodsoft @vbaranov @zachdaniel