1.27.0-0.0.2: [fix] ledger u2f chrome 91 #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorjdawson
commented
Jun 9, 2021
| @@ -46,18 +46,19 @@ | |||
| "prettier": "^2.0.5", | |||
| "rimraf": "^3.0.0", | |||
| "rollup": "^1.27.5", | |||
| "rollup-plugin-svelte": "^5.0.3", | |||
| "rollup-plugin-svelte": "^6.1.1", | |||
There was a problem hiding this comment.
Fixes svelte compilation issue
taylorjdawson
commented
Jun 9, 2021
| @@ -6,8 +6,7 @@ module.exports = { | |||
| }, | |||
| extends: [ | |||
| 'plugin:@typescript-eslint/recommended', | |||
| 'prettier/@typescript-eslint', | |||
| 'plugin:prettier/recommended' | |||
| 'prettier' | |||
There was a problem hiding this comment.
I needed to update our eslint/prettier setup as I was getting some conflicting formatting issues between the two. It's a good time to do this as this is the approach that prettier recommends and follows the design principle of separation of concerns.
lnbc1QWFyb24
approved these changes
Jun 9, 2021
taylorjdawson
changed the title
|
Fixes #577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.