Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove imToken does not support wallet_switchEthereumChain flag #1921

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

xwartz
Copy link
Contributor

@xwartz xwartz commented Sep 26, 2023

Description

This PR updates the SDK to support imToken's wallet_switchEthereumChain method, as imToken has introduced support for this method since April 29, 2022. The current version of the SDK includes a flag indicating that imToken does not support wallet_switchEthereumChain. However, this flag is no longer accurate and needs to be removed to enable seamless integration with imToken.

Changes Made:

  • Removed the 'imToken does not support wallet_switchEthereumChain' flag from the SDK codebase.
  • Tested the modified SDK with the latest version of imToken to ensure compatibility and verify the successful usage of wallet_switchEthereumChain.

By updating the SDK to align with imToken's capabilities, developers using imToken will have access to the full functionality of wallet_switchEthereumChain, enhancing their experience and enabling smoother interaction with Ethereum chains. Please review and merge this PR to ensure compatibility and improved integration between imToken and the SDK.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and updates!

@Adamj1232 Adamj1232 merged commit 34634ab into blocknative:develop Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants