-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Metamask SDK integration #1908
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Release - 2.24.14
…M in client, remove SDK from wallet name as that is customer facing
…instance takes precidence
e957d18
to
263e4cb
Compare
@abretonc7s I have added the MetaMask docs to our official docs site which is part of the Web3-Onboard repo.
|
# @web3-onboard/metamask | ||
|
||
## Wallet module for connecting MetaMask Wallet SDK to web3-onboard | ||
See [MetaMask SDK Developer Docs](https://github.com/MetaMask/metamask-sdk) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to explain a little more here about what can be done with the SDK, connect mobile MM to desktop dapps, etc
I will get any additional verbiage added to our docs pages as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for the collaboration!
Description
Add MetaMask SDK integration to allow MetaMask mobile wallet users to connect.
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errorsDocs Checklist
docs/package.json
file (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn dev
to get the project running athttp://localhost:8080/
Tests with demo app (injected)
Tests with demo app (SDK)