-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/0.9 #307
Merged
Merged
Release/0.9 #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2019
cmeisl
approved these changes
Jun 21, 2019
cmeisl
added a commit
that referenced
this pull request
Jun 21, 2019
* Update snapshots * update to version 0.8.11 * Release/0.9 (#307) * add abi check for ethers * update tests * add ethers support * modify variable names in separate args * fixed getContractMethod calls * fixed transactionQueue bug * also fixes txQueue bug * update getContractMethod to properly create overloaded methods for ethers contracts * correctly assign from property on txOptions object based on ethers or web3 * updated readme * Refactor function to remove unwanted notifications * Add code to call handleNotificationEvent * Update readme * Change value to undefined so that default values work correctly * Add default empty object for proper destructuring * started work to be compatible with ethers v5 * refactored websocket retry logic to be in websockets.js * Update tests * change parameter abi is pulled off of, change to uncheckedsigner * fixed merge conflicts and updated tests * Update readme with ethers contract instantiation example * update getCurrentProvider to allow for ethers * add logic for different ethers versions * add unchecked signer for v4 support * modify eslint config to allow for case declarations * update docs * update readme with compatile ethers versions * add ethers to config validation * small fix to formatting and wrong declaration * Fix bignumber bug with contract gas estimate * Add missing default value for inlineCustomMsgs * Add handleNotificationEvent and remove truffleContract from config validation * Add extra provider checksif not using web3 * Make sure nsfFail event is included in handleNotificationEvent * Add better documentation for handleNotificationEvent * update to version 0.9 * Update documentation for notification events * clarification for txConfirmedClient event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #140
Closes #141
Closes #212
Closes #115