Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to use MulticallProvider instead of StaticJsonRpcProvider when using custom provider #148

Merged
merged 4 commits into from
Jul 12, 2023

Conversation

0x67
Copy link
Contributor

@0x67 0x67 commented Apr 7, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

No option to make aggregated/batched requests.

Issue Number: N/A

What is the new behavior?

Added batched: boolean to ProviderOptions to create MulticallProvider, this should work on any ethers.js v5 providers.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Not sure if this is relevant, but this is my first ever contribution ever to OSS project, so don't hesitate to correct me.

@0x67
Copy link
Contributor Author

0x67 commented Apr 7, 2023

The use case is pretty niche, but if you always call multiple methods and/or multiple contracts, this can significantly reduce the time needed to complete the requests.

@0xslipk 0xslipk self-requested a review May 15, 2023 12:41
@0xslipk
Copy link
Member

0xslipk commented May 15, 2023

The use case is pretty niche, but if you always call multiple methods and/or multiple contracts, this can significantly reduce the time needed to complete the requests.

Amazing PR. thank you so much @0x67. I will take a look this week.

@0xslipk 0xslipk added documentation Improvements or additions to documentation enhancement New feature or request labels May 15, 2023
@0xslipk 0xslipk enabled auto-merge July 12, 2023 15:09
@0xslipk 0xslipk disabled auto-merge July 12, 2023 15:09
Copy link
Member

@0xslipk 0xslipk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xslipk 0xslipk merged commit 763aef4 into blockcoders:main Jul 12, 2023
0xslipk added a commit that referenced this pull request Oct 12, 2023
…cProvider when using custom provider (#148)"

This reverts commit 763aef4.
0xslipk added a commit that referenced this pull request Oct 12, 2023
…cProvider when using custom provider (#148)" (#153)

This reverts commit 763aef4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants