-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: a system for non developers to augment developer system #524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (1)
- .github/workflows/desktop-app-release.yaml: Evaluated as low risk
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.
Files not reviewed (1)
- .github/workflows/desktop-app-release.yaml: Evaluated as low risk
Comments suppressed due to low confidence (1)
crates/goose-server/src/state.rs:63
- Remove the dbg! macro as it is used for debugging and should not be in production code.
dbg!("Skipping MemorySystem (GOOSE_SERVER__MEMORY not set)");
@@ -21,15 +36,34 @@ impl AppState { | |||
pub fn new(provider_config: ProviderConfig, secret_key: String) -> Result<Self> { | |||
let provider = factory::get_provider(provider_config.clone())?; | |||
let mut agent = Agent::new(provider); | |||
|
|||
dbg!("Adding DeveloperSystem"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the dbg! macro as it is used for debugging and should not be in production code.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
crates/goose-server/src/state.rs
Outdated
let has_hints = has_goosehints_file(); | ||
|
||
if !in_git && !has_hints { | ||
dbg!("Adding NonDeveloperSystem"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the dbg! macro as it is used for debugging and should not be in production code.
dbg!("Adding NonDeveloperSystem"); | |
agent.add_system(Box::new(NonDeveloperSystem::new())); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
// Add memory system only if GOOSE_SERVER__MEMORY is set to "true" | ||
if let Ok(memory_enabled) = env::var("GOOSE_SERVER__MEMORY") { | ||
if memory_enabled.to_lowercase() == "true" { | ||
dbg!("Adding MemorySystem"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the dbg! macro as it is used for debugging and should not be in production code.
dbg!("Adding MemorySystem"); | |
agent.add_system(Box::new(MemorySystem::new())); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
agent.add_system(Box::new(MemorySystem::new())); | ||
} else { | ||
dbg!("Skipping MemorySystem (GOOSE_SERVER__MEMORY not 'true')"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the dbg! macro as it is used for debugging and should not be in production code.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
} | ||
|
||
dbg!("Adding GooseHintsSystem"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the dbg! macro as it is used for debugging and should not be in production code.
dbg!("Adding GooseHintsSystem"); | |
// dbg!("Adding GooseHintsSystem"); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
|
||
// Implement cache tool functionality | ||
async fn cache(&self, params: Value) -> AgentResult<Vec<Content>> { | ||
let operation = params |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: rename to command
to be consistent with the text editor tool commands in developer system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salman1993 rename operation to command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I see, good catch
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
* v1.0: feat: a system for non developers to augment developer system (#524)
this is a system which augments the developer system with features that a non developer can make use of, running scripts, caching results, crawling, searching etc - without needing to direct towards specific development tools.
This simply adds a new system on top (just one system - only dependency is tempfile) - and it is enabled in the GUI conditionally (if not in a git repo)
Also fixed up some flaky tests on the way.
eg: