feat: implement current developer system as a separate mcp server #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/v1.0: Adds 'instructions' field to InitializeResult (#511)
|
this is very cool - and does make me think - do we want a way to run in-process systems for things are are pretty much always bundled? (but still be a system which could be used out of process) |
baxen
approved these changes
Dec 30, 2024
crates/developer/src/errors.rs
Outdated
| @@ -0,0 +1,69 @@ | |||
| use mcp_core::handler::{ResourceError, ToolError}; | |||
There was a problem hiding this comment.
seems like file this should maybe be part of more central library? but i guess reasonable to wait until we have another (although @michaelneale has a new system that would need these i think)
There was a problem hiding this comment.
Actually after reading, maybe we remove this entirely and only use ToolError from mcp_core
crates/developer/src/main.rs
Outdated
| self.map_agent_result_to_value(result) | ||
| } | ||
|
|
||
| // Convert AgentResult<Vec<Content>> to Result<Value, ToolError> |
There was a problem hiding this comment.
nit: i haven't thought about it too hard, but might be better to just rework the old code a bit to create ToolError?
salman1993
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is still not complete. the tools are working. resource is not working because i think its currently implemented as a static resource but we might need a resource template (dynamic) - not sure yet
tested with MCP inspector:
✅ tools
✅ resources
