Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ldelalande/fix scroll #504

Merged
merged 4 commits into from
Dec 19, 2024
Merged

fix: Ldelalande/fix scroll #504

merged 4 commits into from
Dec 19, 2024

Conversation

lily-de
Copy link
Collaborator

@lily-de lily-de commented Dec 19, 2024

Before:

  • had to manually scroll down to the flying bird gif if user message is very long
  • had to manually scroll down to the flying bird gif after in-line link previews
  • had to manually scroll past tool output bubbles

After

  • always autoscrolls to the bottom so user can see the flying bird gif immediately after pressing enter

Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Ldelalande/fix scroll". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@lily-de lily-de changed the base branch from main to v1.0 December 19, 2024 15:22
@lily-de lily-de changed the title Ldelalande/fix scroll fix: Ldelalande/fix scroll Dec 19, 2024
@lily-de lily-de marked this pull request as ready for review December 19, 2024 15:37
@lily-de lily-de force-pushed the ldelalande/fix-scroll branch from 2bd01cb to f87371f Compare December 19, 2024 16:09
ui/desktop/src/ChatWindow.tsx Outdated Show resolved Hide resolved
@lily-de lily-de force-pushed the ldelalande/fix-scroll branch from f87371f to d942845 Compare December 19, 2024 16:53
@lily-de lily-de marked this pull request as draft December 19, 2024 16:54
ui/desktop/src/ChatWindow.tsx Outdated Show resolved Hide resolved
ui/desktop/src/components/LoadingGoose.tsx Show resolved Hide resolved
@lily-de lily-de marked this pull request as ready for review December 19, 2024 18:58
@lily-de lily-de merged commit 2cd1314 into v1.0 Dec 19, 2024
3 checks passed
michaelneale added a commit that referenced this pull request Dec 19, 2024
* v1.0:
  fix: Ldelalande/fix scroll (#504)
  feat: MCP server sdk (simple version first) (#499)
lifeizhou-ap added a commit that referenced this pull request Dec 20, 2024
* v1.0:
  Update cli-release.yml
  feat: added groq provider (#494)
  fix: use rust tls (#500)
  fix: Ldelalande/fix scroll (#504)
  feat: MCP server sdk (simple version first) (#499)
  tiny change to use most recent in stack (#501)
  stop bubbles filling screen (#495)
  chore: V1.0 release automation (#493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants