Adds command history to rustyline cli #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakiali
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
works for me!
couple improvements that would be nice in the future:
- global history that you can up arrow. nice for when you become ctrl-c happy and then exit out of a session accidentally.
- session history loaded upon a resume (same use case as above, but maybe an easier approach)
michaelneale
added a commit
that referenced
this pull request
Dec 13, 2024
* v1.0: Reduce sleeps in goose rust tests (#464) chore: eslint for ts (#463) Adds command history to rustyline cli (#461) fix: no need for cancel (#462) chore: cargo fmt ci check (#448) fix: more negative examples and faster classification (#454) turn on user prompting (#453) Fix typos and run cargo fmt (#447) fix: ready/notification prompts (#382) Raise error if viewing a file greater than 2MB (#449) feat: Improve edit prompting (#446) [cli] Resumes most recent modified session if no session name provided (#444) add in a key for goosed and tests
jsibbison-square
added a commit
that referenced
this pull request
Dec 15, 2024
* v1.0: doc: basic docs and rename types (#471) Move resource and more types to mcp-core (#470) refactor: Move shared models out to mcp-core (#469) feat: drafting mcp (#468) Reduce sleeps in goose rust tests (#464) chore: eslint for ts (#463) Adds command history to rustyline cli (#461) fix: no need for cancel (#462)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to use Up and Down arrows to navigate through command history in the rustyline cli in case they want to reuse something they sent before.