feat: remove FTL ingress in favor of a single HTTP ingress type #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
worstell
force-pushed
the
worstell/20240201-single-http-ingress-type
branch
from
eb0b02e to
671c305
Compare
worstell
commented
Feb 1, 2024
| @@ -0,0 +1,33 @@ | |||
| // Code generated by FTL-Generator, do not edit. | |||
There was a problem hiding this comment.
added this testdata/dependencies directory which gets loaded up and added to the classpath for the detekt tests with type resolution. we can use it to add generated sources likeftl.builtin and ftl.time, ensuring these types get resolved in tests
worstell
commented
Feb 1, 2024
| @@ -16,12 +18,20 @@ import kotlin.test.AfterTest | |||
|
|
|||
| @KotlinCoreEnvironmentTest | |||
| internal class ExtractSchemaRuleTest(private val env: KotlinCoreEnvironment) { | |||
| @BeforeEach | |||
There was a problem hiding this comment.
here's where we add those testdata/dependencies files to the classpath
alecthomas
approved these changes
Feb 1, 2024
We will only support a single HTTP ingress type. If no ingress type is specified in a schema declaration, the default type will be HTTP.
worstell
force-pushed
the
worstell/20240201-single-http-ingress-type
branch
from
671c305 to
b12cbce
Compare
|
Awesome, thanks Lizzy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will only support a single HTTP ingress type. If no ingress type is specified in a schema declaration, the default type will be HTTP.