feat: provide Kotlin API for db connections #753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
alecthomas
requested changes
Jan 9, 2024
kotlin-runtime/ftl-runtime/src/main/kotlin/xyz/block/ftl/database/Db.kt
Outdated
Show resolved
Hide resolved
alecthomas
reviewed
Jan 9, 2024
kotlin-runtime/ftl-runtime/src/main/kotlin/xyz/block/ftl/database/Db.kt
Outdated
Show resolved
Hide resolved
alecthomas
reviewed
Jan 9, 2024
alecthomas
reviewed
Jan 9, 2024
worstell
force-pushed
the
worstell/20240108-dbconn
branch
3 times, most recently
from
2d7176a to
349d6b4
Compare
worstell
force-pushed
the
worstell/20240108-dbconn
branch
8 times, most recently
from
61db968 to
35d2773
Compare
worstell
force-pushed
the
worstell/20240108-dbconn
branch
from
3f65e47 to
400e2db
Compare
alecthomas
reviewed
Jan 12, 2024
| assert.NoError(t, err) | ||
|
|
||
| var exists bool | ||
| query := `SELECT EXISTS(SELECT datname FROM pg_catalog.pg_database WHERE datname = $1);` |
| val host = uri.host ?: throw IllegalArgumentException("Missing host in DSN.") | ||
| val port = if (uri.port != -1) uri.port.toString() else throw IllegalArgumentException("Missing port in DSN.") | ||
| val database = uri.path.trimStart('/') | ||
| val parameters = uri.query?.replace("&", "?") ?: "" |
| "connectrpc.com/connect" | ||
| "github.com/alecthomas/assert/v2" | ||
| _ "github.com/amacneil/dbmate/v2/pkg/driver/postgres" |
|
Oh is this redundant now? |
yeah, had intended for these to be split into two PRs (this with the API implementation and the other with schema parsing), but i think since the latter was based on this branch and both commits showed up on github (probably needed to rebase to fix this) it was confusing. going to assume the stamp on the other PR includes these changes and close this 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schema parsing to follow