Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deterministically colour deployment names in timeline #471

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

alecthomas
Copy link
Collaborator

@alecthomas alecthomas commented Oct 10, 2023

Currently uses a curated fixed table, which we can adjust for dark/light modes.

Possible future enhancements:

  • Replace colours with on-the-fly generation if we can figure out a way to make the colours not ugly.
  • Separate colours for module name and deployment, so it's easier to map module name.

Before:
Screenshot 2023-10-10 at 11 40 54 am

After:
Screenshot 2023-10-10 at 11 40 15 am

Currently uses a fixed table, which we can adjust for dark/light modes,
or could replace with on-the-fly generation if we can figure out a way
to make the colours not ugly.
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
fnv1a 1.1.1 None +0 4.34 kB schwarzkopfb

@alecthomas alecthomas merged commit 9731534 into main Oct 10, 2023
9 checks passed
@alecthomas alecthomas deleted the aat/coloured-deployments branch October 10, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant