Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use GetSchema instead of PullSchema when getting full schema in ftl schema diff #3915

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jvmakine
Copy link
Contributor

@jvmakine jvmakine commented Jan 7, 2025

No description provided.

@jvmakine jvmakine requested a review from Copilot January 7, 2025 02:22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

frontend/cli/cmd_schema_diff.go:136

  • The error message should be more descriptive. Suggestion: 'url %s: failed to retrieve schema using GetSchema: %w'.
return nil, fmt.Errorf("url %s: failed to get schema: %w", url.String(), err)
@alecthomas alecthomas mentioned this pull request Jan 7, 2025
@jvmakine jvmakine merged commit b3a8ff3 into main Jan 7, 2025
65 checks passed
@jvmakine jvmakine deleted the juho/schema-service-refactor-2 branch January 7, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant