fix: remove log streaming endpoint #3850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
Open
Open
stuartwdouglas
force-pushed
the
stuartwdouglas/remove-stream-logs
branch
4 times, most recently
from
4b925be to
8d03c6a
Compare
|
Aha! Yes, great point! |
alecthomas
reviewed
Dec 23, 2024
backend/runner/runner.go
Outdated
| func (s *Service) streamLogsLoop(ctx context.Context, send func(request *ftlv1.StreamDeploymentLogsRequest) error) error { | ||
| delay := time.Millisecond * 500 | ||
| func (s *Service) streamLogsLoop(ctx context.Context) { | ||
| for { |
There was a problem hiding this comment.
Replace with channels.IterContext()!
stuartwdouglas
force-pushed
the
stuartwdouglas/remove-stream-logs
branch
from
8d03c6a to
2f12bee
Compare
The runner now writes this to the timeline service directly
stuartwdouglas
force-pushed
the
stuartwdouglas/remove-stream-logs
branch
from
b233fcd to
d37c279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runner now writes this to the timeline service directly