refactor: simplify the common case of ranging over a channel w/ cancellation #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
commented
Dec 19, 2024
| }) | ||
| case <-ctx.Done(): | ||
| return | ||
| case <-time.After(1 * time.Second): |
There was a problem hiding this comment.
This doesn't seem to do anything - as there's nothing in the for loop outside the select, it will just drop straight back into the select.
alecthomas
force-pushed
the
aat/simplify-channel-range
branch
2 times, most recently
from
883adac to
3c97e4e
Compare
…llation
Simplifies this:
for {
select {
case <-ctx.Done():
return
case msg := <-events:
// DO STUFF
}
}
To this:
for msg := range channels.IterContext(ctx, events) {
// DO STUFF
}
alecthomas
force-pushed
the
aat/simplify-channel-range
branch
from
3c97e4e to
8089bea
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies this:
To this: