New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: all references without module get normalized to its module #3829

Merged

matt2e merged 2 commits into main from matt2e/schema-ref-normalization-2

Dec 20, 2024

Collaborator

matt2e commented Dec 19, 2024 •

edited

Loading

Visit each child before validating it's parent, so normalization of child nodes is done before validation of parent nodes.
A bunch of tests used ref.Module == "" to refer to builtins, but we want all schema to be fully qualified.


          fix: all references without module refer get normalized to its module

680dbea

matt2e requested a review from alecthomas as a code owner

December 19, 2024 22:18

alecthomas mentioned this pull request

Open


          improve qualification code

22006b9

matt2e mentioned this pull request

fix: handle refs without module #3817

Closed

matt2e merged commit e085fc2 into main

62 checks passed

matt2e deleted the matt2e/schema-ref-normalization-2 branch

December 20, 2024 03:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet