Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove rust proto gen from build tasks #3783

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

worstell
Copy link
Contributor

No description provided.

@worstell worstell requested a review from alecthomas as a code owner December 16, 2024 20:20
This was referenced Dec 16, 2024
@worstell worstell force-pushed the worstell/20241216-remove-rust-protos-from-build-all branch from eae1fa8 to a3c4c70 Compare December 16, 2024 20:25
@@ -165,16 +165,15 @@ build-extension: pnpm-install
@mk {{EXTENSION_OUT}} : frontend/vscode/src frontend/vscode/package.json -- "cd frontend/vscode && rm -f ftl-*.vsix && pnpm run compile"

# Build the sqlc-ftl-gen plugin, used to generate FTL schema from SQL
build-sqlc-gen-ftl: build-protos
build-sqlc-gen-ftl: build-rust-protos
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll eventually use this task for the plugin release

@@ -0,0 +1,6 @@
version: v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think you can just call this buf.gen.yaml, I don't think there's anything that would automatically pick it up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's currently in the same directory as the buf.gen.yaml we use for other protos- i could move it to the sqlc-gen-ftl directory but i figured we may use rust/rust protos for other things

@worstell worstell merged commit 9c55bc7 into main Dec 17, 2024
92 checks passed
@worstell worstell deleted the worstell/20241216-remove-rust-protos-from-build-all branch December 17, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants