New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[started] close kafka consumer when runner exits #3747

Closed

matt2e wants to merge 1 commit into main from matt2e/pubsub/close-consumer

Collaborator

matt2e commented Dec 15, 2024 •

edited

Loading

closes #3473

Added integration test to see if runner exits the consumer group when ending
... but we don't pass the test yet
... ftl kill is not currently killing runners.
Adding a signal handler in consumer doesn't work, because other signal handler calls os.Exit() without giving enough time for consumer to fully close.


          add test to make sure consumer group is exited

af9fa51

github-actions bot changed the title ~~add test to make sure consumer group is exited~~ test: add to make sure consumer group is exited

ftl-robot mentioned this pull request

Open

matt2e changed the title ~~test: add to make sure consumer group is exited~~ [started] close kafka consumer when runner exits

matt2e closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet