feat(Juho): new provisioners #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvmakine
force-pushed
the
juho/new-provisioners
branch
from
b6fe018 to
7f84eab
Compare
Open
jvmakine
force-pushed
the
juho/new-provisioners
branch
from
23814de to
6343313
Compare
jvmakine
force-pushed
the
juho/new-provisioners
branch
15 times, most recently
from
abff5b2 to
d273520
Compare
Remove provisioner specific domain model, and use schemas and schema updates as the provisioning domain model. As a follow up, we need to type provisioners so we don't need to have RuntimeEvent sum type, and integrate the provisioners properly with the schema service
jvmakine
requested review from
stuartwdouglas and
wesbillman
and removed request for
a team
…ners unnecessarily
jvmakine
force-pushed
the
juho/new-provisioners
branch
from
b231725 to
6fad629
Compare
stuartwdouglas
approved these changes
Dec 10, 2024
alecthomas
reviewed
Dec 11, 2024
| } | ||
|
|
||
| message VerbRuntimeEvent { | ||
| string id = 1; |
There was a problem hiding this comment.
What does "id" mean in all these?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes provisioner specific
resources.protodomain model, and converts provisioners to operate on the schema directly instead.Result of a provisioner plugin is a set of update events to the schema, and the input is a schema diff.
Follow-ups: