Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Kube tests again #3593

Merged
merged 1 commit into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ jobs:
go test -v -race -tags integration -run '^${{ matrix.test }}$' $(git grep -l '^//go:build integration' | xargs grep -l '^func ${{ matrix.test }}' | xargs -I {} dirname ./{})
infrastructure-shard:
name: Shard Infrastructure Tests
if: github.event_name != 'pull_request' || github.event.action == 'enqueued' || contains( github.event.pull_request.labels.*.name, 'run-all')
# if: github.event_name != 'pull_request' || github.event.action == 'enqueued' || contains( github.event.pull_request.labels.*.name, 'run-all')
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.extract-tests.outputs.matrix }}
Expand Down
4 changes: 2 additions & 2 deletions backend/provisioner/scaling/k8sscaling/k8s_scaling.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func (r *k8sScaling) StartDeployment(ctx context.Context, module string, deploym
}
delCtx := log.ContextWithLogger(context.Background(), logger)
go func() {
time.Sleep(time.Second * 10)
time.Sleep(time.Second * 20)
err := r.deleteOldDeployments(delCtx, module, deploymentKey)
if err != nil {
logger.Errorf(err, "Failed to delete old deployments")
Expand Down Expand Up @@ -215,7 +215,7 @@ func (r *k8sScaling) GetEndpointForDeployment(ctx context.Context, module string
// TODO: hard coded port? It's hard to deal with as we might not have the lease
// I think requiring this port is fine for now
return optional.Some(url.URL{Scheme: "http",
Host: fmt.Sprintf("%s:8893", deployment),
Host: fmt.Sprintf("%s:8892", deployment),
}), nil
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ func TestKubeScaling(t *testing.T) {
assert.Equal(t, "Bonjour, Bob!!!", response)
}),
func(t testing.TB, ic in.TestContext) {
t.Logf("Checking for no failure during redeploys")
done.Store(true)
routineStopped.Wait()
err := failure.Load()
Expand Down
2 changes: 1 addition & 1 deletion backend/runner/runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ import (

type Config struct {
Config []string `name:"config" short:"C" help:"Paths to FTL project configuration files." env:"FTL_CONFIG" placeholder:"FILE[,FILE,...]" type:"existingfile"`
Bind *url.URL `help:"Endpoint the Runner should bind to and advertise." default:"http://127.0.0.1:8893" env:"FTL_BIND"`
Bind *url.URL `help:"Endpoint the Runner should bind to and advertise." default:"http://127.0.0.1:8892" env:"FTL_BIND"`
Key model.RunnerKey `help:"Runner key (auto)."`
ControllerEndpoint *url.URL `name:"ftl-endpoint" help:"Controller endpoint." env:"FTL_ENDPOINT" default:"http://127.0.0.1:8892"`
ControllerPublicKey *identity.PublicKey `name:"ftl-public-key" help:"Controller public key in Base64. Temporarily optional." env:"FTL_CONTROLLER_PUBLIC_KEY"`
Expand Down
2 changes: 1 addition & 1 deletion charts/ftl/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
name: ftl-http-ingress
port:
number: 8891
- path: /xyz.block.ftl.v1beta1.provisioner.ProvisionerService/
- path: /xyz.block.ftl.provisioner.v1beta1.ProvisionerService/
pathType: Prefix
backend:
service:
Expand Down
4 changes: 3 additions & 1 deletion charts/ftl/templates/provisioner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ spec:
{{- if .Values.provisioner.env }}
{{- toYaml .Values.provisioner.env | nindent 12 }}
{{- end }}
- name: FTL_BIND
value: "http://0.0.0.0:{{ (index .Values.provisioner.ports 0).containerPort }}"
ports:
{{- range .Values.provisioner.ports }}
- name: {{ .name }}
Expand All @@ -51,7 +53,7 @@ spec:
{{- else }}
httpGet:
path: /healthz
port: 8892
port: {{ (index .Values.provisioner.ports 0).containerPort }}
initialDelaySeconds: 1
periodSeconds: 2
timeoutSeconds: 2
Expand Down
4 changes: 3 additions & 1 deletion charts/ftl/templates/runner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ data:
{{- end }}
- name: FTL_ARTEFACT_REGISTRY
value: "{{ .Values.registry.repository }}"
- name: FTL_BIND
value: "http://0.0.0.0:{{ (index .Values.runner.ports 0).containerPort }}"
- name: FTL_ARTEFACT_REGISTRY_ALLOW_INSECURE
value: "{{ .Values.registry.allowInsecure }}"
- name: FTL_ARTEFACT_REGISTRY_USERNAME
Expand All @@ -88,7 +90,7 @@ data:
{{- else }}
httpGet:
path: /healthz
port: 8893
port: {{ (index .Values.runner.ports 0).containerPort }}
initialDelaySeconds: 1
periodSeconds: 2
timeoutSeconds: 2
Expand Down
7 changes: 1 addition & 6 deletions charts/ftl/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -180,16 +180,11 @@ runner:

ports:
- name: http
containerPort: 8893
containerPort: 8892
protocol: TCP

readinessProbe: null

headlessService:
ports:
- port: 8893
targetPort: 8893

podAnnotations:
proxy.istio.io/config: |
holdApplicationUntilProxyStarts: true
Expand Down
Loading