generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: first metric (verb call counter) #2130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniseli
changed the title
Dli/toy metric and log
chore: first metric (verb call counter)
Jul 22, 2024
Open
deniseli
force-pushed
the
dli/toy-metric-and-log
branch
from
July 22, 2024 20:12
c896c64
to
2ecc680
Compare
deniseli
requested review from
a team and
worstell
and removed request for
a team
July 22, 2024 20:17
wesbillman
reviewed
Jul 22, 2024
wesbillman
approved these changes
Jul 23, 2024
Comment on lines
+937
to
+946
logger := log.FromContext(ctx) | ||
|
||
requestCounter, err := otel.GetMeterProvider().Meter("ftl.call").Int64Counter( | ||
"requests", | ||
metric.WithDescription("Count of FTL verb calls via the controller")) | ||
if err != nil { | ||
logger.Errorf(err, "Failed to instrument otel metric `ftl.call.requests`") | ||
} else { | ||
requestCounter.Add(ctx, 1, metric.WithAttributes(attribute.String("ftl.module.name", req.Msg.Verb.Module), attribute.String("ftl.verb.name", req.Msg.Verb.Name))) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! We can start with this for testing, and move into a dedicated file in the future to keep the controller light :)
Linking issue: #2194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrument our first metric. Next: check if this metric pipes through to DD correctly.
Locally, the output via
just otel-stream
looks like:Interestingly, it looks like the metric logging races in a slightly inconsistent way. If you call a verb that calls another verb, you would expect just one verb to get bumped to 1 first, and then the other verb. Sometimes, it does behave that way. However, other times, the first time it appears in
otel-stream
will already be with both verbs. So essentially, there is no guarantee that transient values actually show up in the stream, but the ultimate value will be correct.This does appear the report the correct count in even error cases. e.g. I tried calling
echo
before the deploy was done, so that the verb call would fail without calling out totime
. It would correctly log a single call in that case. And if you made another successful call afterwards, the metric would correctly increment to include both successful calls.