chore: refactor out separate dal and sql packages for cronjobs
#1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
alecthomas
reviewed
Jun 21, 2024
deniseli
force-pushed
the
dli/split-dal-soup
branch
from
480bf77 to
46441f6
Compare
deniseli
force-pushed
the
dli/split-dal-soup
branch
from
46441f6 to
c7c0744
Compare
deniseli
changed the title
dal and sql pacakges for leases and cronjobsdal and sql pacakges for cronjobs
alecthomas
reviewed
Jul 2, 2024
alecthomas
reviewed
Jul 2, 2024
deniseli
changed the title
dal and sql pacakges for cronjobsdal and sql packages for cronjobs
alecthomas
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of #1567: This PR refactors
cronjobsdal and sql packages out from the parent controller package. I'm breaking this refactor into many PRs to combat merge conflicts.Ultimate plan for the refactor:
controller/domain/{dal,sql}packages hold all the query logic for each domainDcontains certain use cases (i.e. functions) that need to exec queries from a different domainE,D/dalwill callE/dal. If those queries spanning multiple domains need to be merged into a single transaction, thenD/dalwill create a wrapper transaction that gets bundled with aqtxfor each domain that gets queried.CreateDeploymentis an example of this that should eventually be refactored out ofcontroller/dalintocontroller/deployment/dal.controller/dalwill cease to exist.controller/sqlwill not contain any queries. Instead, it will house top-level db artifacts (e.g.sql/schema)In the meantime, while this refactor is in progress,
controller/dalwill contain methods that are yet to be pulled out.This PR does not yet generalize the top-level
Txlogic becausecontroller/dalis still the only dal package that uses it.