feat: ftltest supports pubsub #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
matt2e
commented
Jun 11, 2024
| } | ||
|
|
||
| type SubscriptionHandle[E any] struct { | ||
| Topic *schema.Ref |
There was a problem hiding this comment.
TopicHandle and SubscriptionHandle's fields are accessed by ftltest, so have been made public
alecthomas
approved these changes
Jun 11, 2024
go-runtime/ftl/ftltest/fake.go
Outdated
| fsm: newFakeFSMManager(), | ||
| mockMaps: map[uintptr]mapImpl{}, | ||
| allowMapCalls: false, | ||
| configValues: map[string][]byte{}, | ||
| secretValues: map[string][]byte{}, | ||
| globalTopic: pubsub.New[pubSubEvent](), |
There was a problem hiding this comment.
Let's pull all the pubsub code out into a separate struct and file, and forward to it from fakeFTL.
go-runtime/ftl/ftltest/fake.go
Outdated
| defer f.pubSubLock.Unlock() | ||
|
|
||
| logger := log.FromContext(ctx).Scope("pubsub") | ||
| results := []SubscriptionResult[E]{} |
There was a problem hiding this comment.
Suggested change
| results := []SubscriptionResult[E]{} | |
| var results []SubscriptionResult[E] |
tip: avoids an allocation
| google.golang.org/protobuf v1.34.1 // indirect | ||
| ) | ||
|
|
||
| replace github.com/TBD54566975/ftl => ./../../../../../.. |
matt2e
force-pushed
the
matt2e/ftltest-pubsub
branch
from
8fb5b5f to
8bdce7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1598
Adds:
funcin the argument)