fix: check for invalid function calls into external modules #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
matt2e
commented
Jun 7, 2024
|
|
||
| if lhsType, ok := pctx.pkg.TypesInfo.TypeOf(selExpr.X).(*types.Named); ok && lhsType.Obj().Pkg().Path() == ftlPkgPath { | ||
| // Calling a function on an FTL type | ||
| if lhsType.Obj().Name() == ftlTopicHandleTypeName && selExpr.Sel.Name == "Publish" { |
There was a problem hiding this comment.
Checking for github.com/TBD54566975/ftl/go-runtime/ftl and TopicHandle separately because the actual full name also includes [AnEventType], which we don't care about
alecthomas
approved these changes
Jun 7, 2024
| // checks if the is directly: | ||
| // - calling external verbs | ||
| // - publishing to an external module's topic | ||
| func validateCallExpr(pctx *parseContext, node *ast.CallExpr) { |
There was a problem hiding this comment.
We do want this to be recursive at some point, such that if you call a function that calls a verb, we can track that.
There was a problem hiding this comment.
This should already be checking this case because we aren't just checking within functions defined as verbs:
//ftl:verb
func Verb(...) (...) {
helper()
...
}
func helper() {
externalmodule.Verb() // <--- Error here
}| if lhsIsExternal && strings.HasPrefix(lhsPkgPath, "ftl/") { | ||
| if _, ok := pctx.pkg.TypesInfo.TypeOf(selExpr.Sel).(*types.Signature); ok { | ||
| // can not call functions in external modules directly | ||
| pctx.errors.add(errorf(node, "can not call verbs in other modules directly: use ftl.Call(…) instead")) |
worstell
approved these changes
Jun 7, 2024
…l verbs # Conflicts: # go-runtime/compile/schema_test.go
matt2e
force-pushed
the
matt2e/external-publish
branch
from
d5ee26f to
24126bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1640
Checks for:
ftl.Call(...)Both of these compile-time checks are not fool proof, any indirection will mean these checks don't catch it. But it is good to catch what we can.
eg:
Added a separate issue for this for pubsub as it may not be as high a priority: #1703