fix: add a build.lock file to gate the buildengine #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safeer
changed the title
Open
safeer
commented
Jun 5, 2024
safeer
requested review from
a team,
matt2e and
wesbillman
and removed request for
a team
alecthomas
approved these changes
Jun 10, 2024
wesbillman
reviewed
Jun 10, 2024
| return nil, err | ||
| } | ||
| lock := flock.New(lockFile) | ||
| locked, err := lock.TryLock() |
alecthomas
added a commit
that referenced
this pull request
Jun 11, 2024
This reverts commit e711523. ``` === Failed === FAIL: buildengine TestDissallowMultipleEngines (0.00s) /home/runner/work/ftl/ftl/buildengine/engine_test.go:65: Did not expect an error but got: failed to lock file at: /home/runner/.ftl/build.lock DONE 383 tests, 1 skipped, 1 failure in 115.533s Error: === RUN TestDissallowMultipleEngines buildengine/engine_test.go:65: Did not expect an error but got: failed to lock file at: /home/runner/.ftl/build.lock ```
alecthomas
added a commit
that referenced
this pull request
Jun 11, 2024
…1732) This reverts commit e711523. ``` === Failed === FAIL: buildengine TestDissallowMultipleEngines (0.00s) /home/runner/work/ftl/ftl/buildengine/engine_test.go:65: Did not expect an error but got: failed to lock file at: /home/runner/.ftl/build.lock DONE 383 tests, 1 skipped, 1 failure in 115.533s Error: === RUN TestDissallowMultipleEngines buildengine/engine_test.go:65: Did not expect an error but got: failed to lock file at: /home/runner/.ftl/build.lock ``` cc @safeer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1636