feat: publish pubsub events #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matt2e
commented
May 31, 2024
matt2e
commented
- pipes module calls for publishing events through to the controller to the db
- fake implementation for tests not included
- added TopicEventKey. It will be generally useful I think, but also required for how db events are set up needing a "key" column
Open
Closed
alecthomas
approved these changes
May 31, 2024
| return fmt.Errorf("failed to marshal event: %w", err) | ||
| } | ||
| _, err = client.PublishEvent(ctx, connect.NewRequest(&ftlv1.PublishEventRequest{ | ||
| Topic: &schemapb.Ref{Module: reflection.Module(), Name: topic}, |
There was a problem hiding this comment.
What if you're publishing to a module that's from another module?
There was a problem hiding this comment.
Good point, I've made it an issue and part of the pubsub epic
#1640
matt2e
force-pushed
the
matt2e/pubsub-publish
branch
from
e92d316 to
0032a47
Compare
# Conflicts: # backend/protos/xyz/block/ftl/v1/ftl.pb.go
matt2e
force-pushed
the
matt2e/pubsub-publish
branch
from
0032a47 to
19d3672
Compare
jonathanj-square
pushed a commit
that referenced
this pull request
Jun 4, 2024
- pipes module calls for publishing events through to the controller to the db - fake implementation for tests not included - added TopicEventKey. It will be generally useful I think, but also required for how db events are set up needing a "key" column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.