chore: update CODEOWNERS #1218
Merged
chore: update CODEOWNERS #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Let's wait a few weeks until Denise is more confident in the code base before adding her, but good idea to add Matt. |
|
Just to clarify: we don't require approvals for CODEOWNERS because we're following a "review-after-merge" process in general. Once we feel people are confident enough in the codebase we'll add them, but while they're getting up to speed it seems a bit safer to have normal full PR approval enforced. We started this process with Wes, and continued with Lizzy and Matt. |
worstell
force-pushed
the
worstell/20240409-update-codeowners
branch
from
6fffecb to
6a58bb8
Compare
alecthomas
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.