Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower case response fields don't show in response and don't warn or error #848

Closed
wesbillman opened this issue Jan 30, 2024 · 2 comments · Fixed by #1016
Closed

Lower case response fields don't show in response and don't warn or error #848

wesbillman opened this issue Jan 30, 2024 · 2 comments · Fixed by #1016
Assignees
@matt2e
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@wesbillman
Copy link
Collaborator

If a verb has a response struct like

type SIOPV2AuthRequest struct {
	scope string
}

The http response will not have scope and it's pretty difficult to debug
@wesbillman wesbillman added the bug Something isn't working label Jan 30, 2024
@github-project-automation github-project-automation bot moved this to Todo in FTL Jan 30, 2024
@alecthomas
Copy link
Collaborator

This is normal Go behaviour but we could warn/error about it, because FTL can't do anything with these fields.

@alecthomas
Copy link
Collaborator

This should error.

@alecthomas alecthomas added the good first issue Good for newcomers label Feb 8, 2024
@matt2e matt2e self-assigned this Mar 5, 2024
@alecthomas alecthomas mentioned this issue Mar 5, 2024
Open
@matt2e matt2e mentioned this issue Mar 5, 2024
Merged
matt2e added a commit that referenced this issue Mar 5, 2024
@matt2e
fix: lowercase request and response fields should produce an error (#…
8dc0d59 
…1016)

Fixes #848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt2e matt2e

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: lowercase request and response fields should produce an error block/ftl
3 participants
@alecthomas @wesbillman @matt2e